[coreboot-gerrit] Change in ...coreboot[master]: soc/apollolake: Generate DMAR table

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30990 )

Change subject: soc/apollolake: Generate DMAR table
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/30990/5/src/soc/intel/apollolake/acpi.c 
File src/soc/intel/apollolake/acpi.c:

https://review.coreboot.org/#/c/30990/5/src/soc/intel/apollolake/acpi.c@247 
PS5, Line 247: 		!(MCHBAR32(DEFVTBAR) & VTBAR_ENABLED))
> Because if GFX is diasbled (for some reason), VTD can still be active and we need to generate DMAR t […]

Yes, second line. And I meant indentation relative to the `if`.
Currently the second line of the condition aligns with the body
(`return current;`). This shouldn't be the case.