Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40335 )
Change subject: device: Add provision for multiple PCI segments
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40335/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40335/7//COMMIT_MSG@11
PS7, Line 11: SoC user can override CONFIG_PCI_SEGMENT_GROUPS from respective
: SoC Kconfig if SoC has support for multiple PCI segment.
What is the impact of selecting this Kconfig. […]
It was my idea to have a Kconfig in common code. As Subrata described,
we would (for now) only have chip specific code that is affected.
Nevertheless, I would prefer to have it in src/device/ because the
overall concept of PCI segment groups is not chip specific.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40335
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90660c5cfd8af5bb40e36bb409e534541c786cae
Gerrit-Change-Number: 40335
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 04 May 2020 22:38:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment