Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39413 )
Change subject: mb/google/volteer: configure L1Substate for PCIe
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39413/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/ripto/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39413/1/src/mainboard/google/voltee...
PS1, Line 5: register "PcieRpL1Substates[8]" = "2"
is that an issuetracker bug number? it seems to be invalid on our end.
We don't have partner bug as this issue fixed long time back for ES1.
And it'll affect warm reboot with NVMe memory:After warm reboot, NVMe is not detected.
Do you want to create partner bug for this and add partner bug info?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39413
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie85bf71c43427e326ef2ba674da4566f8f51495a
Gerrit-Change-Number: 39413
Gerrit-PatchSet: 4
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 11 Mar 2020 09:00:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment