Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35168 )
Change subject: soc/intel/skylake: enable GMM in devicetree
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35168/2/src/soc/intel/skylake/chip_...
File src/soc/intel/skylake/chip_fsp20.c:
https://review.coreboot.org/c/coreboot/+/35168/2/src/soc/intel/skylake/chip_...
PS2, Line 445: dev
What if 'dev' is NULL? Then, 'dev->enabled' is a null pointer dereference...
*looks above* oh no...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35168
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21409adf85b70bccc30dd8e12a03ad7921544b3c
Gerrit-Change-Number: 35168
Gerrit-PatchSet: 2
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 30 Aug 2019 17:31:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment