Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41392 )
Change subject: libpayload/cbgfx: Remove gap between adjacent boxes ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41392/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/41392/1/payloads/libpayload/drivers... PS1, Line 82: while (d > INT32_MAX || d < INT32_MIN) { Faster:
int shift = log2(d >> 31); if (shift > 0) { n >>= shift; d >>= shift; }
https://review.coreboot.org/c/coreboot/+/41392/1/payloads/libpayload/drivers... PS1, Line 233: int draw_box(const struct rect *box, const struct rgb_color *rgb) off-topic, but I think we should try to get rid of this and just only use draw_rounded_box() everywhere at some point (maybe make a draw_box(pos_rel, dim_rel rgb) that's just a thin wrapper which sets thickness and radius to zero).