Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43897 )
Change subject: soc/intel/tigerlake: Simplify is-device-enabled checks
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43897/5/src/soc/intel/tigerlake/rom...
File src/soc/intel/tigerlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/43897/5/src/soc/intel/tigerlake/rom...
PS5, Line 30: m_cfg->IgdDvmt50PreAlloc = m_cfg->InternalGfx ? 0xFE : 0;
My +1 is because I don't really like this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43897
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I791273e5dd633cd1d6218b322106e2f62a393259
Gerrit-Change-Number: 43897
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 26 Jul 2020 21:28:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment