Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32533 )
Change subject: sb/{ICH7,NM10,PCH}: Use common watchdog_off function ......................................................................
Patch Set 14: Code-Review+2
(3 comments)
https://review.coreboot.org/#/c/32533/12/src/southbridge/intel/common/Makefi... File src/southbridge/intel/common/Makefile.inc:
https://review.coreboot.org/#/c/32533/12/src/southbridge/intel/common/Makefi... PS12, Line 55: ramstage-$(CONFIG_SOUTHBRIDGE_INTEL_COMMON_WATCHDOG) += watchdog.c
We are talking a little past each other (or rather, I'm […]
Done
https://review.coreboot.org/#/c/32533/12/src/southbridge/intel/common/tco.h File src/southbridge/intel/common/tco.h:
https://review.coreboot.org/#/c/32533/12/src/southbridge/intel/common/tco.h@... PS12, Line 25: #define TCO_TMR_HLT (1 << 11)
Done
Ack
https://review.coreboot.org/#/c/32533/14/src/southbridge/intel/fsp_rangeley/... File src/southbridge/intel/fsp_rangeley/watchdog.c:
https://review.coreboot.org/#/c/32533/14/src/southbridge/intel/fsp_rangeley/... PS14, Line 37: David, Fei, can you confirm if this bit is writable on Rangeley?