Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35119 )
Change subject: soc/sifive/fu540: Support booting from SD card ......................................................................
Patch Set 7:
(13 comments)
https://review.coreboot.org/c/coreboot/+/35119/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35119/4//COMMIT_MSG@7 PS4, Line 7: soc/sifive/fu540: add support boot from sdcard
Done
Done
https://review.coreboot.org/c/coreboot/+/35119/1/src/mainboard/sifive/hifive... File src/mainboard/sifive/hifive-unleashed/media.c:
https://review.coreboot.org/c/coreboot/+/35119/1/src/mainboard/sifive/hifive... PS1, Line 94: switch (read32((uint32_t *)FU540_MSEL)) {
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35119/1/src/mainboard/sifive/hifive... PS1, Line 95: case 6:
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35119/1/src/mainboard/sifive/hifive... PS1, Line 96: case 10:
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35119/1/src/mainboard/sifive/hifive... PS1, Line 97: case 15:
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35119/1/src/mainboard/sifive/hifive... PS1, Line 98: return &spi_mdev.rdev;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35119/1/src/mainboard/sifive/hifive... PS1, Line 98: return &spi_mdev.rdev;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35119/1/src/mainboard/sifive/hifive... PS1, Line 99: case 11:
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35119/1/src/mainboard/sifive/hifive... PS1, Line 100: return &sd_mdev.rdev;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35119/1/src/mainboard/sifive/hifive... PS1, Line 100: return &sd_mdev.rdev;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/35119/1/src/mainboard/sifive/hifive... PS1, Line 101: }
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35119/1/src/mainboard/sifive/hifive... PS1, Line 102: return NULL;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/35119/4/src/mainboard/sifive/hifive... File src/mainboard/sifive/hifive-unleashed/media.c:
https://review.coreboot.org/c/coreboot/+/35119/4/src/mainboard/sifive/hifive... PS4, Line 37: 512
Done
Done