[coreboot-gerrit] [S] Change in libgfxinit[master]: gma: add a Turn_Off procedure to clear the graphic configuration

[Nico Huber (Code Review)]

Attention is currently required from: Jérémy Compostella.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/69938 )

Change subject: gma: add a Turn_Off procedure to clear the graphic configuration
......................................................................

Patch Set 1:

(2 comments)

File common/hw-gfx-gma.adb:

https://review.coreboot.org/c/libgfxinit/+/69938/comment/8d0a47aa_b39ed356 
PS1, Line 629:       Power_And_Clocks.Pre_All_Off;
This procedure doesn't clean up anything libgfxinit set up but rather
disables things that libgfxinit doesn't know how to use.

https://review.coreboot.org/c/libgfxinit/+/69938/comment/a368d37e_c4720508 
PS1, Line 630:       Connectors.Pre_All_Off;
             :       Display_Controller.All_Off;
             :       Connectors.Post_All_Off;
             :       PLLs.All_Off;
             :       Power_And_Clocks.Post_All_Off;
This part should be covered by calling Update_Outputs with all ports set to
`Disabled`. Do you happen to know if the Clear_Fences below is necessary to
make the GOP work? If not, we might already have everything we need in the API.