[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/cmn: Include ME specification configuration at common

[Maximilian Brune (Code Review)]

Attention is currently required from: Felix Singer, Tarun Tuli, Subrata Banik, Dinesh Gehlot, Kapil Porwal, Angel Pons, Arthur Heymans, Werner Zeh.

Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73128 )

Change subject: soc/intel/cmn: Include ME specification configuration at common
......................................................................

Patch Set 1:

(3 comments)

File src/soc/intel/common/block/cse/Kconfig:

https://review.coreboot.org/c/coreboot/+/73128/comment/f9040f31_2643ddbe 
PS1, Line 211: 	default n
> add `depends on SOC_INTEL_COMMON_BLOCK_CSE`

Is there a difference now between SOC_INTEL_COMMON_BLOCK_CSE and SOC_INTEL_CSE_HAVE_SPEC_SUPPORT? Don't they imply the same?

https://review.coreboot.org/c/coreboot/+/73128/comment/7b23e386_621313dc 
PS1, Line 259: if SOC_INTEL_CSE_HAVE_SPEC_SUPPORT
> > Put this line above SOC_INTEL_COMMON_BLOCK_ME_SPEC_11. […]

Even better

https://review.coreboot.org/c/coreboot/+/73128/comment/97dce214_b42b0e5c 
PS1, Line 261: config ME_SPEC_11
> > That's what I mean. […]

Yeah but only if they give you some kind of useful information. In this case they don't.