Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34359 )
Change subject: mainboard: Add Lenovo ThinkPad T440p
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG@27
PS3, Line 27: - Mainboard serial number is invalid
No good way to fix because the at24rf08c code is built when VENDOR_LENOVO is selected, not going to […]
I've found that the serial number is read via port 0x1630/0x1634, which is implemented in EmulatedEepromDxe in the OEM UEFI image, but I still don't know how to initialize the "emulated EEPROM" to make it work. I only know it runs after smbus from the UEFI module dependencies.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I56a6b94197789a83731d8b349b8ba6814bf57ca2
Gerrit-Change-Number: 34359
Gerrit-PatchSet: 8
Gerrit-Owner: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 17 Aug 2019 13:58:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexander Couzens
lynxis@fe80.eu
Comment-In-Reply-To: Iru Cai (vimacs)
mytbk920423@gmail.com
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment