29 Sep
2020
29 Sep
'20
9:40 a.m.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45288 )
Change subject: amdfwtool: Apply the change of config file to hudson ......................................................................
Patch Set 23:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45288/23/src/southbridge/amd/pi/hud... File src/southbridge/amd/pi/hudson/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45288/23/src/southbridge/amd/pi/hud... PS23, Line 100: #SMUFWM_FILE=$(top)/$(FIRMWARE_LOCATE)/SmuFirmware$(FIRMWARE_TYPE).sbin Would these get removed later, or is this to allow an option to build easily without the cfg file still?
--
To view, visit https://review.coreboot.org/c/coreboot/+/45288
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id953c3e4b5c075815d4cc86bc8cd7ca0ebdf6de7
Gerrit-Change-Number: 45288
Gerrit-PatchSet: 23
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Dave Frodin dave.frodin@se-eng.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Matt Papageorge matthewpapa07@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Sep 2020 07:40:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment