Attention is currently required from: Sridhar Siricilla, Tim Wawrzynczak, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59360 )
Change subject: soc/intel, soc/common: Add method to determine the cpu type mask
......................................................................
Patch Set 1:
(3 comments)
File src/soc/intel/common/block/acpi/cpu_hybrid.c:
https://review.coreboot.org/c/coreboot/+/59360/comment/ebacbc06_4a7307d2
PS1, Line 18: get_cpu_type
this is only implemented in the following patch. Please order them correctly...
https://review.coreboot.org/c/coreboot/+/59360/comment/9179ec90_efc0a7de
PS1, Line 23: get_cpu_type_bitmask
Where is this called? It's very hard to know what the purpose of all this is, as it's not explained in the commit message.
https://review.coreboot.org/c/coreboot/+/59360/comment/aefa4919_7194d7ea
PS1, Line 25: return global_cpu_type_bitmask;
This is not thread safe and probably should only be consume when all AP have run it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59360
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4ceb24d9bb1e808750bf618c29b2b9ea6d4191b
Gerrit-Change-Number: 59360
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 18 Nov 2021 08:54:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment