Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35849 )
Change subject: superio/nuvoton/nct5104d: Add virtual LDN for simple GPIO IO control
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
looks good to me; printing a warning when the gpio i/o space interface gets disabled when no gpio port is enabled would be good though
https://review.coreboot.org/c/coreboot/+/35849/3/src/superio/nuvoton/nct5104...
File src/superio/nuvoton/nct5104d/superio.c:
https://review.coreboot.org/c/coreboot/+/35849/3/src/superio/nuvoton/nct5104...
PS3, Line 169: }
maybe also print a warning?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35849
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ce99bb44e6f5db684170f4190bdc38a944849f6
Gerrit-Change-Number: 35849
Gerrit-PatchSet: 3
Gerrit-Owner: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 14 Jan 2020 20:44:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment