25 Sep
2019
25 Sep
'19
11:08 p.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35601 )
Change subject: arch/x86: Fix __ROMCC__ automatic prerequisities ......................................................................
Patch Set 1:
(1 comment)
Patrick, this is possibly your territory?
https://review.coreboot.org/c/coreboot/+/35601/1/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35601/1/src/arch/x86/Makefile.inc@1... PS1, Line 164: $(CC_bootblock) -D__ROMCC__ -D__PRE_RAM__ -D__BOOTBLOCK__ $(CPPFLAGS_bootblock) -MM -MT$(objgenerated)/bootblock.inc \ I expected -D__PRE_RAM__ -D__BOOTBLOCK__ to appear in CPPFLAGS_xx but they do not?
--
To view, visit https://review.coreboot.org/c/coreboot/+/35601
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib799c872b5280e2035126f9660e04e51acc4b1a8
Gerrit-Change-Number: 35601
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Sep 2019 21:08:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment