[coreboot-gerrit] Change in coreboot[master]: mb/google/kukui: Support eDP panels via PS8640

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34516 )

Change subject: mb/google/kukui: Support eDP panels via PS8640
......................................................................

Patch Set 42:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34516/40/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/Kconfig:

https://review.coreboot.org/c/coreboot/+/34516/40/src/mainboard/google/kukui... 
PS40, Line 49: 	select DRIVER_PARADE_PS8640 if KUKUI_HAS_PS8640
> nit: at that point might as well just do […]

We're going to have lots of followers that all need this so I think a HAS is better than explicit board?

https://review.coreboot.org/c/coreboot/+/34516/40/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/panel_ps8640.c:

https://review.coreboot.org/c/coreboot/+/34516/40/src/mainboard/google/kukui... 
PS40, Line 60: 8
> nit: I'd write I2C addresses as 0x08 since that's how you usually see them on schematics

Done