Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48860 )
Change subject: soc/intel/alderlake: Refactor meminit code
......................................................................
Patch Set 2:
Patch Set 2:
@Furquan, AFAIK, new FSP doesn't need DQ map for SODIMM memory. Maybe we can remove it? It will probe and mapping by MRC.
That can be done at the mainboard level, right? i.e. skip DQ map. SoC code would just copy all 0s in that case.
@Subrata, Am I right?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48860
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b75e856f1f2aa34bb7a91913147faf3037e7cfb
Gerrit-Change-Number: 48860
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 23 Dec 2020 17:45:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment