[coreboot-gerrit] Change in ...coreboot[master]: soc/amd/common: Refactor S3 helpers

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31490 )

Change subject: soc/amd/common: Refactor S3 helpers
......................................................................

Patch Set 5:

(1 comment)

ou

https://review.coreboot.org/#/c/31490/5/src/soc/amd/common/block/pi/agesawra... 
File src/soc/amd/common/block/pi/agesawrapper.c:

https://review.coreboot.org/#/c/31490/5/src/soc/amd/common/block/pi/agesawra... 
PS5, Line 315: 	Status = OemS3Save(&RtbParams->S3DataBlock);
> Right, OemS3Save() should only be called if amd_dispatch() does not return errors so we know S3DataB […]

That would be acceptable. Please implement code in which OemS3Save is only called if dispatch did not returned error.