[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Speed up postcar loading using intermediate cac...

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34791 )

Change subject: soc/intel/cannonlake: Speed up postcar loading using intermediate caching
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34791/5/src/soc/intel/cannonlake/ro... 
File src/soc/intel/cannonlake/romstage/romstage.c:

https://review.coreboot.org/c/coreboot/+/34791/5/src/soc/intel/cannonlake/ro... 
PS5, Line 135: enable_ramstage_caching
> I'd not expect this to happen if the CPU is in non-evict mode

yes, i don't think there would be any cache cohencency issue here

https://review.coreboot.org/c/coreboot/+/34791/5/src/soc/intel/cannonlake/ro... 
PS5, Line 177: 	enable_ramstage_caching(top_of_ram, top_of_ram_size);
> Maybe add a function like postcar_frame_add_romcache() but for both setting up the postcar frame MTR […]

got it, we can do that