Attention is currently required from: Paul Menzel.
Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64002 )
Change subject: soc/intel: Return ACPI_S4 as previous sleep state
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64002/comment/20959f45_ea688d35
PS1, Line 8:
Mention the problem, that suspend to disk currently does not(?) work?
Done
https://review.coreboot.org/c/coreboot/+/64002/comment/d29cea95_f76bc81b
PS1, Line 10: acpi_sleep_from_pm1()
Nit: Fits on the line above.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/64002
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3fb3dc428a749db80293e51a04a2096514a7b689
Gerrit-Change-Number: 64002
Gerrit-PatchSet: 3
Gerrit-Owner: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 03 May 2022 15:16:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment