Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32262 )
Change subject: vboot: refactor OPROM code ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/32262/7/src/security/vboot/Kconfig File src/security/vboot/Kconfig:
https://review.coreboot.org/#/c/32262/7/src/security/vboot/Kconfig@180 PS7, Line 180: and any other native display initialization code is not run
This doesn't seem to reflect the code on older x86 platforms. AFAIUI, […]
The second sentence describes how things are supposed to work if the platform sets this flag. The platforms you're describing (which always init display unconditionally, whether that's via option ROM or native) would not have this flag set. All this does is provide a hint to vboot whether it can assume the display is always enabled or it needs to reboot with a special request in NVRAM to get it turned on.
https://review.coreboot.org/#/c/32262/7/src/security/vboot/vboot_handoff.c File src/security/vboot/vboot_handoff.c:
https://review.coreboot.org/#/c/32262/7/src/security/vboot/vboot_handoff.c@8... PS7, Line 84: VBSD_OPROM_LOADED
out of curiosity, I assume `VBSD_OPROM_LOADED` implies more than what the […]
Yes, the whole "oprom" name isn't really accurate anymore, it's a general "we have enabled the display (whatever that takes)" flag. I think the plan is to slowly rename everything to a more generic "display init/available". (This particular flag isn't renamed here because it's going to be eliminated soon anyway, after a few more changes on the vboot side.)