build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48860 )
Change subject: soc/intel/alderlake: Refactor meminit code
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48860/2/src/soc/intel/alderlake/mem...
File src/soc/intel/alderlake/meminit.c:
https://review.coreboot.org/c/coreboot/+/48860/2/src/soc/intel/alderlake/mem...
PS2, Line 265: case MIXED: /* For a mixed topology, channel 1 can only be memory-down */
line over 96 characters
https://review.coreboot.org/c/coreboot/+/48860/2/src/soc/intel/alderlake/mem...
PS2, Line 274: die("Invalid memory topology on channel 1 (%d)\n", info->topology);
line over 96 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48860
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2b75e856f1f2aa34bb7a91913147faf3037e7cfb
Gerrit-Change-Number: 48860
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 22 Dec 2020 21:53:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment