Attention is currently required from: Julius Werner.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/82533?usp=email )
Change subject: libpayload: x86: Move Multiboot header to include file
......................................................................
Patch Set 7:
(1 comment)
File payloads/libpayload/arch/x86/multiboot_header.inc:
https://review.coreboot.org/c/coreboot/+/82533/comment/8bc8fec1_d6ee4fd0?usp... :
PS7, Line 34: .align 4
This should not be here since this is included directly into the instruction stream of another funct […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82533?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I59a22dfe36044b4dd64a5b028a134be7a7d02a48
Gerrit-Change-Number: 82533
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 22 May 2024 03:51:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org