Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30384 )
Change subject: nb/intel/broadwell: Add an option for where verstage starts
......................................................................
Patch Set 42: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/30384/42//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/30384/42//COMMIT_MSG@20
PS42, Line 20: memory.
Took me a moment to realize why this is related. Might be worth
to remind the reader that separate verstage implies RW romstage :)
https://review.coreboot.org/#/c/30384/42/src/soc/intel/broadwell/romstage/ra...
File src/soc/intel/broadwell/romstage/raminit.c:
https://review.coreboot.org/#/c/30384/42/src/soc/intel/broadwell/romstage/ra...
PS42, Line 48: f
rather short identifier ^^
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30384
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I900233cadb3c76da329fb98f93917570e633365f
Gerrit-Change-Number: 30384
Gerrit-PatchSet: 42
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 12 May 2019 10:37:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment