Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41757 )
Change subject: drivers/vpd: Fix VPD speed regressions on non-x86 devices ......................................................................
Patch Set 3:
(2 comments)
this looks good to me, but will that work on x86 bootblock/romstage since you've used static?
This restriction has been eliminated (at least for static data initialized to zero). See CB:40535.
https://review.coreboot.org/c/coreboot/+/41757/3/src/drivers/vpd/vpd.c File src/drivers/vpd/vpd.c:
https://review.coreboot.org/c/coreboot/+/41757/3/src/drivers/vpd/vpd.c@123 PS3, Line 123: done = true;
If CBMEM is not available, the rdevs are initialized from memory mapped flash. […]
That's why cbmem_add_cros_vpd() calls init_vpd_devs_from_cbmem() directly at the end, to switch the rdevs to CBMEM backing without going through this function again.
https://review.coreboot.org/c/coreboot/+/41757/3/src/drivers/vpd/vpd.c@157 PS3, Line 157: } else {
do we need this else?
Sorry, that was a leftover from another attempt. Fixed.