Attention is currently required from: Intel coreboot Reviewers, Krystian Hebel, Michał Kopeć, Michał Żygowski, Paul Menzel.
Filip Lewiński has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/83727?usp=email )
Change subject: soc/intel/cannonlake: Hook up Intel TXT FSP UPDs
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/83727/comment/5cf5466a_7cba485f?usp... :
PS3, Line 152: m_cfg->ApStartupBase = 1; /* Set to non-zero, FSP does NULL check */
[Replaced](https://review.coreboot.org/c/coreboot/+/83727/4.. […]
The change breaks builds for some models because of the conditional inline definition of stop_this_cpu()
```
CC romstage/cpu/x86/lapic/lapic_cpu_stop.o
src/cpu/x86/lapic/lapic_cpu_stop.c:51:6: error: redefinition of 'stop_this_cpu'
51 | void stop_this_cpu(void)
| ^
src/include/cpu/x86/lapic.h:173:29: note: previous definition is here
173 | static __always_inline void stop_this_cpu(void)
| ^
1 error generated.
```
working on fixing it
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83727?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibca1c7c8a5335dab8af4888aee4c60683b72746d
Gerrit-Change-Number: 83727
Gerrit-PatchSet: 6
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: coreboot org
coreboot.org@gmail.com
Gerrit-CC: Filip Lewiński
filip.lewinski@3mdeb.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Thu, 03 Apr 2025 08:14:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Filip Lewiński
filip.lewinski@3mdeb.com
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com