Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32513 )
Change subject: soc/intel/cannonlake: Clean up cannonlake_memcfg_init
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32513/3/src/soc/intel/cannonlake/include/soc...
File src/soc/intel/cannonlake/include/soc/cnl_memcfg_init.h:
https://review.coreboot.org/#/c/32513/3/src/soc/intel/cannonlake/include/soc...
PS3, Line 62: struct spd_info spd;
I don't think we can treat different slot independently. […]
How is it supposed to work then?
Please contact FSP developers, as those configurations are quite common.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32513
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I686a85996858204c20fd05ef24787a0487817c34
Gerrit-Change-Number: 32513
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Sun, 05 May 2019 17:12:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Comment-In-Reply-To: Philip Chen
philipchen@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment