Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35224 )
Change subject: soc/intel/common/block/cse: Add helper function heci_send_receive
......................................................................
Patch Set 8:
(3 comments)
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35224/7/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/35224/7/src/soc/intel/common/block/...
PS7, Line 462: size_t *rcv_sz)
Minor: this fits on the previous line (line length limit is 96 characters)
Done
https://review.coreboot.org/c/coreboot/+/35224/7/src/soc/intel/common/block/...
PS7, Line 465: Heci Send Failed
To be consistent with the other messages in this file, please use "HECI: send failed\n"
Done
https://review.coreboot.org/c/coreboot/+/35224/7/src/soc/intel/common/block/...
PS7, Line 471: Heci receive Failed
"HECI: receive failed\n"
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35224
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic95239eef8591d3aadf56a857c97f3f1e12b16ac
Gerrit-Change-Number: 35224
Gerrit-PatchSet: 8
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 09 Sep 2019 05:16:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment