Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31900 )
Change subject: device: Rename scan_static_bus() -> enable_static_devices() ......................................................................
Patch Set 2: -Code-Review
Patch Set 1: Code-Review-2
blocking this for now. no need to merge this if it's overrun tomorrow
Of course I had the best intentions to look deeper into getting rid of .scan_bus() but didn't take the time ._.
Now I don't even recall what could have overrun this. The first three patches look sane to me. The first two simply rename and consolidate things. The third allows bridge devices behind LPC (actually I guess now we should just always scan bridges every- where? I don't see why not).
I'll look into cases that could rely on predictable numbers for I2C (SMBus) buses now, hoping to get rid of scan_generic_bus() and scan_smbus(), too.