Chris Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33802 )
Change subject: mb/google/octopus/variants/fleex: Enable EMR function for Grob360S
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/33802/1/src/mainboard/google/octopus/variant...
File src/mainboard/google/octopus/variants/fleex/gpio.c:
https://review.coreboot.org/#/c/33802/1/src/mainboard/google/octopus/variant...
PS1, Line 33: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 0, DEEP, NONE, Tx1RxDCRx0, DISPUPD), /* GPIO_140 -- PEN_RESET */
line over 96 characters
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33802
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia220dc0d3051b79b110b4df66df108f701776478
Gerrit-Change-Number: 33802
Gerrit-PatchSet: 3
Gerrit-Owner: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Zhou
chris_zhou@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: JoeJ Chang
joej_chang@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 26 Jun 2019 09:14:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment