[coreboot-gerrit] Change in ...coreboot[master]: src/soc/intel/braswell/southcluster.c: Correct serial IRQ support

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29398 )

Change subject: src/soc/intel/braswell/southcluster.c: Correct serial IRQ support
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/29398/5/src/soc/intel/braswell/Kconfig 
File src/soc/intel/braswell/Kconfig:

https://review.coreboot.org/#/c/29398/5/src/soc/intel/braswell/Kconfig@137 
PS5, Line 137: 
             : config ENABLE_SERIRQ
             : 	bool "Enable Serial IRQ"
             : 	default n
             : 	help
             : 	  Enable Serial IRQ
             : 
             : config SERIRQ_CONTINUOUS_MODE
             : 	bool "Serial IRQ continuous mode"
             : 	default n
             : 	depends on ENABLE_SERIRQ
             : 	help
             : 	  Enable Serial IRQ continuous mode
> In 'old' code base it was disabled, so to avoid causing problems when SERIRQ becomes enabled this fe […]

I do not see any board which enables or sets SERIRQ mode in Kconfig menu. Probably it would be better to make these options hidden and be selected per mainboard in mainboard specific options.