Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37171 )
Change subject: drives/amd/agesa: remove legacy wrapper and separate CAR teardown ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Patch Set 1:
Michal, we need to get all the things on the same branch on gerrit.
Can you drop 'git log master..' so I know what you got there already.
- ea53d244ea (HEAD -> master) northbridge/amd/pi: drop BINARYPI_LEGACY_WRAPPER
- fa2dd4e2b9 drives/amd/agesa: remove legacy wrapper and separate CAR teardown
- 2d52f08035 nb/amd/pi: support for boards without BINARYPI_LEGACY_WRAPPER
- 1e989a5de0 northbridge/amd/pi: define the number of IOAPICs
| * f3758b6738 (origin/master, origin/HEAD) AGESA,binaryPI: Move SCI enable outside table creation
Setting the same topic won't do?
No, topic is nothing but a UI thing. There are some old Change-Ids that I want to bring back here.
Let me rebase things on one branch. I will take about 5 of your commits and 2 or 3 of my old cleanups from 2017. There might be some valuable commentary there with old Change-Ids.