Attention is currently required from: Tarun Tuli, Kapil Porwal.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69698 )
Change subject: soc/intel/meteorlake: Rename method is_eom to is_manuf_mode ......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/meteorlake/me.c:
https://review.coreboot.org/c/coreboot/+/69698/comment/84b37565_baf1d479 PS1, Line 79: is_manuf_mode
Please notice the negation (!) in return statement.
Kapil, Hmm..I miss the negation. But, is_manuf_mode() naming has no meaning.
You may need to rename the function to is_manuf_mode_enabled() as per definition as this function is verifying particular mode. is_manuf_mode() doesn't reflect enable or disable mode of manufacturing mode while the function return true or false.
Please note the function definition is verifying particular mode (enabled) of manufacturing mode, so the function name should have the particular mode.
Given the helper function definition, is_eom() is more suitable than is_manuf_mode(). You may check references to EOM in the Intel ME BIOS spec.