Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41719 )
Change subject: amd/picasso: Load x86 microcode from CBFS modules
......................................................................
Patch Set 7:
(1 comment)
Patch Set 7:
Patch Set 7:
Do I need to click "resolve" for each comment?
yes. patches can only be submitted when all comments are marked as resolved. that was a change maybe a year or a year and a half ago
https://review.coreboot.org/c/coreboot/+/41719/5/src/soc/amd/picasso/include...
File src/soc/amd/picasso/include/soc/cpu.h:
https://review.coreboot.org/c/coreboot/+/41719/5/src/soc/amd/picasso/include...
PS5, Line 20: #define RAVEN1_B0_CPUID 0x00810f10
Looks exactly as above?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41719
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib08a65b93c045afc97952a809670c85831c0faf7
Gerrit-Change-Number: 41719
Gerrit-PatchSet: 7
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Zheng Bao
zheng.bao@amd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 02 Jun 2020 07:58:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment