build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55476 )
Change subject: device: Add log_resource() ......................................................................
Patch Set 2:
(2 comments)
File src/include/device/resource.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121585): https://review.coreboot.org/c/coreboot/+/55476/comment/0b092c74_39cf5224 PS2, Line 95: #define LOG_RESOURCE(type, dev, res) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-121585): https://review.coreboot.org/c/coreboot/+/55476/comment/4fb700a6_43bcacfb PS2, Line 96: if (CONFIG(DEBUG_RESOURCES)) log_resource(type, dev, res, __func__, __LINE__) trailing statements should be on next line