[coreboot-gerrit] [XS] Change in coreboot[main]: intel/cmm/block: use CONFIG_SMM_TSEG_SIZE in sa_get_tseg_size function

[Wonkyu Kim (Code Review)]

Attention is currently required from: Anil Kumar K, Bora Guvendik, Jamie Ryu, Jeremy Compostella, Jérémy Compostella, Paul Menzel, Subrata Banik.

Wonkyu Kim has posted comments on this change by Wonkyu Kim. ( https://review.coreboot.org/c/coreboot/+/84210?usp=email )

Change subject: intel/cmm/block: use CONFIG_SMM_TSEG_SIZE in sa_get_tseg_size function
......................................................................

Patch Set 3:

(2 comments)

File src/soc/intel/common/block/systemagent/systemagent_early.c:

https://review.coreboot.org/c/coreboot/+/84210/comment/51620cdb_b27f0321?usp... :
PS2, Line 155: 	return sa_get_gsm_base() - sa_get_tseg_base();
> > We checked internally and got recommendation not to calculate it as CONFIG_SMM_TSEG_SIZE is passed […]

FSP team mentioned that Tseg size is passed by UPD and memory map(relationship for  Tesg base and gsm base) can also be changed in future silicon.  So, FSP team recommend use Tseg size which is passed to UPD which is CONFIG_SMM_TSEG_SIZE.

File src/soc/intel/common/block/systemagent/systemagent_early.c:

https://review.coreboot.org/c/coreboot/+/84210/comment/7256a005_c963df5b?usp... :
PS3, Line 151: 	if (CONFIG_SMM_TSEG_SIZE) {
             : 		return CONFIG_SMM_TSEG_SIZE;
             : 	}
             :
> what is this for ?

If CONFIG_SMM_TSEG_SIZE is defined use CONFIG_SMM_TSEG_SIZE rather than calculation.