HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33774 )
Change subject: sb/amd/sb{700,800}: Cleanup index manipulations ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
out of topic: sb800.c: we have "index = (dev->path.pci.devfn & 0x3) / 2" I don't know if (path.pci.devfn & 0x3) is an even number
https://review.coreboot.org/#/c/33774/1/src/southbridge/amd/sb700/sb700.c File src/southbridge/amd/sb700/sb700.c:
https://review.coreboot.org/#/c/33774/1/src/southbridge/amd/sb700/sb700.c@a1... PS1, Line 107: why it is set = -1 ?
https://review.coreboot.org/#/c/33774/1/src/southbridge/amd/sb800/sb800.c File src/southbridge/amd/sb800/sb800.c:
https://review.coreboot.org/#/c/33774/1/src/southbridge/amd/sb800/sb800.c@a2... PS1, Line 231: out of topic, but why "-1" ?