Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33824 )
Change subject: mb/google/hatch: Create Akemi variant ......................................................................
Patch Set 23:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33824/17/src/mainboard/google/hatch... File src/mainboard/google/hatch/variants/akemi/gpio.c:
https://review.coreboot.org/c/coreboot/+/33824/17/src/mainboard/google/hatch... PS17, Line 22: gpio_table
Can you please group and order this list in alphabetical order for GPP_*? It just makes it easy to f […]
Done
https://review.coreboot.org/c/coreboot/+/33824/17/src/mainboard/google/hatch... PS17, Line 100: early_gpio_table
Actually, thinking more, I'd rather not have the baseboard provide a weak function and just enforc […]
Done