Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43176 )
Change subject: mb/google/zork: Add VBOOT_VBNV_CMOS flag
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43176/3/src/mainboard/google/zork/K...
File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/43176/3/src/mainboard/google/zork/K...
PS3, Line 103: select VBOOT_VBNV_CMOS
Indeed it is. You merged it today :) https://review.coreboot.org/c/coreboot/+/41816. […]
Fair enough, it's been so long since I uploaded it, I guess I just thought the code was already merged.
As far as why it's conditional, it's just not in place yet. I agree that we need to get it working, and that will be one of the next pieces I work on.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43176
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I19ec139c8f098da630eeab199fec55297e3d977c
Gerrit-Change-Number: 43176
Gerrit-PatchSet: 3
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Thu, 09 Jul 2020 16:14:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment