Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35034 )
Change subject: arch/x86: Restrict use of _car_global[start|end]
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35034/2/src/arch/x86/assembly_entry...
File src/arch/x86/assembly_entry.S:
https://review.coreboot.org/c/coreboot/+/35034/2/src/arch/x86/assembly_entry...
PS2, Line 44: shrl $2, %ecx
Please move this to its own patch so we can land the fix on its own.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35034
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36c858a4f181516d4c61f9fd1d5005c7d2c06057
Gerrit-Change-Number: 35034
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 28 Aug 2019 22:07:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment