Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33116 )
Change subject: Kconfig: Make stage cache kconfig selection proper ......................................................................
Patch Set 22:
(3 comments)
https://review.coreboot.org/c/coreboot/+/33116/22/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/33116/22/src/Kconfig@256 PS22, Line 256: is can be? USE is for doing it while this is indicating support.
https://review.coreboot.org/c/coreboot/+/33116/22/src/Kconfig@270 PS22, Line 270: !NO_STAGE_CACHE Indicating no stage cache implies the use of a stage cache?
https://review.coreboot.org/c/coreboot/+/33116/22/src/cpu/intel/haswell/Make... File src/cpu/intel/haswell/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/33116/22/src/cpu/intel/haswell/Make... PS22, Line 13: y Why aren't these 'y's using $(CONFIG_USE_EXTERNAL_STAGE_CACHE) instead of the guard?