Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32466 )
Change subject: google/kukui: Raising the CPU frequency
......................................................................
Patch Set 2:
According to pmic spec (MT6358_PMIC_Data_Sheet_V1.3.pdf), the voltage will be stable in 200us.
It takes about 700us from increasing voltage to end of mt6358_init().
So, it's safe to raising CPU frequency after mt6538_init()
Thanks for the great info. Can state that in comment before we call the function to raise CPU freq?
So that if someone is trying to optimize they won't miss it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32466
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I703ffcb99367f87e6792a72485f5634e0505e5ac
Gerrit-Change-Number: 32466
Gerrit-PatchSet: 2
Gerrit-Owner: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Weiyi Lu
weiyi.lu@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Comment-Date: Fri, 26 Apr 2019 09:31:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment