[coreboot-gerrit] Change in coreboot[master]: mainboard: Add Lenovo ThinkPad T440p

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34359 )

Change subject: mainboard: Add Lenovo ThinkPad T440p
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34359/3//COMMIT_MSG@26 
PS3, Line 26: - The Fn key is on by default
> The Fn key issue can be resolved by (in the OEM firmware it uses 0x1604/0x1600, but 0x66/0x62 should […]

Yes 62/66 is safe to use.
You could read read the EC version register to detect when this change is necessary.

https://review.coreboot.org/c/coreboot/+/34359/3/Documentation/mainboard/len... 
File Documentation/mainboard/lenovo/t440p.md:

https://review.coreboot.org/c/coreboot/+/34359/3/Documentation/mainboard/len... 
PS3, Line 32: Please see :doc:`../../northbridge/intel/haswell/mrc.bin`.
> I see other docs using this. […]

It was used when Sphinx didn't support ../ in path. That has been fixed and is now safe to use.