[coreboot-gerrit] Change in ...coreboot[master]: ec/lenovo/h8: Add function to query sense state

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29204 )

Change subject: ec/lenovo/h8: Add function to query sense state
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/29204/2/src/ec/lenovo/h8/sense.c 
File src/ec/lenovo/h8/sense.c:

https://review.coreboot.org/#/c/29204/2/src/ec/lenovo/h8/sense.c@25 
PS2, Line 25:  * Unlikely that all register will be zero after booting has
            :  * finished.
> Patrick, I still wonder what this sentence refers to, […]

the EC.
You are correct, if we see the first bit there's no guarantee that the other bits are valid, as we don't have a insight into the EC firmware.
My tests however showed no toggling bits once it doesn't read as zero any more.
I'll update the comment that this is based on observation.