Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39135 )
Change subject: src/soc/tigerlake: Add memory configuration support for Jasper Lake ......................................................................
Patch Set 21:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39135/14/src/soc/intel/tigerlake/in... File src/soc/intel/tigerlake/include/soc/meminit_jsl.h:
https://review.coreboot.org/c/coreboot/+/39135/14/src/soc/intel/tigerlake/in... PS14, Line 132: )
Meera, Furquan articulated exactly what I was referring to. […]
Ack
https://review.coreboot.org/c/coreboot/+/39135/21/src/soc/intel/tigerlake/me... File src/soc/intel/tigerlake/meminit_jsl.c:
https://review.coreboot.org/c/coreboot/+/39135/21/src/soc/intel/tigerlake/me... PS21, Line 101: const struct mb_cfg *board_cfg,
Nit: It can be accomodated in the previous line as commented by Furquan in the header file.
Ack