Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47343 )
Change subject: device/dram/ddr3: Drop unused MRS helpers
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Patch Set 1:
there's some useful stuff in there; I'd prefer replacing northbridge code that basically does the same with calls to these functions
I've thought about doing so. However, I'd rather replace this code with a tried and tested implementation from some northbridge.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47343
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4cf2fc0d07a772886e90fba4f66591a7b0a40e6c
Gerrit-Change-Number: 47343
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 28 Mar 2021 12:49:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment