Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38937 )
Change subject: mb/google/hatch: set wifi sar for Akemi
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38937/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/akemi/variant.c:
https://review.coreboot.org/c/coreboot/+/38937/1/src/mainboard/google/hatch/...
PS1, Line 58: return filename;
i don't see any changes? was there another patch that was supposed to be uploaded?
This whole function isn't necessary anyway, unless you're going to have more than one SAR file for Akemi (based on SKU).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38937
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I549e00c800985ecf8702220b276885385d928cd1
Gerrit-Change-Number: 38937
Gerrit-PatchSet: 1
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 18 Feb 2020 23:31:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Gerrit-MessageType: comment