Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32585 )
Change subject: mb/lenovo/*: Add support for VBOOT on 8MiB devices
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/32585/4/src/mainboard/lenovo/t420/Kconfig
File src/mainboard/lenovo/t420/Kconfig:
https://review.coreboot.org/#/c/32585/4/src/mainboard/lenovo/t420/Kconfig@31
PS4, Line 31: config VBOOT
Can we move some of the flags into https://review.coreboot. […]
no as:
VBOOT_VBNV_CMOS is board specific. The range should be reserved in cmos.layout.
HAS_RECOVERY_MRC_CACHE is board specific. It requires the corresponding entry in the FMAP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32585
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icb7b263ed86551cc53e1db7babccaca6b3ae2fe6
Gerrit-Change-Number: 32585
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 06 May 2019 08:55:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-MessageType: comment