Tim Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46071 )
Change subject: mb/ocp/deltalake: Use BMC version to represent ec version
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46071/1/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/46071/1/src/mainboard/ocp/deltalake...
PS1, Line 31: * In deltalake, BMC version is used to represent ec version.
Please add a comment that with current versions of OpenBMC, how major/minor versions are represented […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46071
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I388efd749170f0ebbb4dd4d32199675d92cc018e
Gerrit-Change-Number: 46071
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Ryback Hung
ryback.hung%quantatw.com@gtempaccount.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 07 Oct 2020 02:15:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Gerrit-MessageType: comment