Attention is currently required from: Saurabh Mishra, Kangheui Won, Paul Menzel, Rizwan Qureshi. Saurabh Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63707 )
Change subject: vendorcode/intel/fsp: Update FSP header file for Alder Lake N FSP v3133.00 ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63707/comment/5f094058_9a6fd74e PS1, Line 11: Include
include
Done
https://review.coreboot.org/c/coreboot/+/63707/comment/76496b1c_c37db472 PS1, Line 9: The headers added are generated as per FSP v3133.00 : Previous FSP version was v3054.02 : Changes Include:
Please improve the formatting.
Formatting is used from previous CL: https://review.coreboot.org/c/coreboot/+/62129
https://review.coreboot.org/c/coreboot/+/63707/comment/fbc5f140_687b6440 PS1, Line 12: - UPD Enable eMMC Controller Offset Added in FspsUpd.h
But you remove *Enable eMMC Controller*?
Corrected.
https://review.coreboot.org/c/coreboot/+/63707/comment/dcd07224_0916cebb PS1, Line 12: Added
added
Done